fix(orchestrator-form-widgets): avoid ActiveTextInput crash when fetch:response:value resolves to missing key#3074
Merged
karthikjeeyar merged 4 commits intoMay 11, 2026
Conversation
…safely Treat null or undefined JSONata results as empty string for ActiveTextInput fetch response values to avoid UI breakage while editing dynamic selector keys, and add tests for applySelectorString strict/lenient behavior.
lokanandaprabhu
requested review from
a team,
christoph-jerolimov,
karthikjeeyar and
lholmquist
as code owners
Changed Packages
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3074 +/- ##
==========================================
+ Coverage 60.94% 60.96% +0.01%
==========================================
Files 2067 2067
Lines 63931 63974 +43
Branches 16599 16598 -1
==========================================
+ Hits 38965 38999 +34
- Misses 24733 24739 +6
- Partials 233 236 +3
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
…g selectors Wrap JSONata compile/evaluate in applySelector with clear errors and lenient empty string/array fallbacks where already used for fetch responses. Skip invalid jsonata: body fields in useRequestInit instead of failing the whole request. Extend changeset and tests. Co-authored-by: Cursor <cursoragent@cursor.com>
…l input Coerce or empty non-string template results in evaluateFetchResponseSelectorTemplate, treat non-string JSONata results as empty in lenient applySelector paths, and guard SchemaUpdater object extraction. Update tests and changeset. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
karthikjeeyar
approved these changes
May 11, 2026
Member
karthikjeeyar
left a comment
karthikjeeyar
left a comment
There was a problem hiding this comment.
Verified locally, handles the invalid inputs or partial JSON data and doesn't break the UI anymore.
/approve
/lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixes: https://redhat.atlassian.net/browse/RHDHBUGS-3110
This fixes a runtime failure path in ActiveTextInput when fetch:response:value (JSONata) resolves to undefined/null — common while editing dynamic selector keys with fetch:retrigger.
Screen.Recording.2026-05-08.at.12.15.43.PM.mov
✔️ Checklist